Skip to content

[ST] Add MustGather and publish logs from tests in AZP #109

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

[ST] Add MustGather and publish logs from tests in AZP #109

wants to merge 9 commits into from
+247 −4

Conversation

@im-konge
Copy link
Member

@im-konge im-konge commented Nov 11, 2025 •
edited
Loading

This PR adds LogCollector from Test-Frame to the STs + it adds step for publishing the logs from the failed STs.
The structure of folders used by LogCollector (and KubeResourceManager) looks like this:

├── 2025-11-11-14-25-56
│   └── io.strimzi.kafka.access.KafkaAccessOperatorST
│       └── testAccessToSpecifiedListener
│           └── 1
│               └── main-namespace
│                   ├── deployment
│                   │   └── strimzi-access-operator.yaml
│                   ├── events.log
│                   ├── kafka
│                   │   └── cluster-833282209.yaml
│                   ├── kafkaaccess
│                   │   └── access-833282209.yaml
│                   ├── kafkauser
│                   │   ├── scramsha.yaml
│                   │   └── tls.yaml
│                   ├── pod
│                   │   ├── describe-pod-strimzi-access-operator-76bd5c9699-lfdkq.log
│                   │   └── logs-pod-strimzi-access-operator-76bd5c9699-lfdkq-container-access-operator.log
│                   └── secret
│                       ├── access-833282209.yaml
│                       ├── cluster-833282209-clients-ca-cert.yaml
│                       ├── cluster-833282209-clients-ca.yaml
│                       ├── cluster-833282209-cluster-ca-cert.yaml
│                       ├── cluster-833282209-cluster-ca.yaml
│                       ├── cluster-833282209-cluster-operator-certs.yaml
│                       └── tls.yaml
├── default
│   └── test-files
│       └── io.strimzi.kafka.access.KafkaAccessOperatorST
│           ├── ClusterRole-strimzi-access-operator.yaml
│           ├── ClusterRoleBinding-main-namespace-strimzi-access-operator.yaml
│           ├── CustomResourceDefinition-kafkaaccesses.access.strimzi.io.yaml
│           ├── Deployment-main-namespace-strimzi-access-operator.yaml
│           ├── Namespace-main-namespace.yaml
│           ├── ServiceAccount-main-namespace-strimzi-access-operator.yaml
│           └── testAccessToSpecifiedListener
│               ├── Kafka-main-namespace-cluster-1335100552.yaml
│               ├── Kafka-main-namespace-cluster-269819268.yaml
│               ├── Kafka-main-namespace-cluster-833282209.yaml
│               ├── Kafka-main-namespace-cluster-960384484.yaml
│               ├── KafkaAccess-main-namespace-access-1335100552.yaml
│               ├── KafkaAccess-main-namespace-access-269819268.yaml
│               ├── KafkaAccess-main-namespace-access-833282209.yaml
│               ├── KafkaAccess-main-namespace-access-960384484.yaml
│               ├── KafkaUser-main-namespace-scramsha.yaml
│               ├── KafkaUser-main-namespace-tls.yaml
│               └── Secret-main-namespace-tls.yaml
└── strimzi-debug-0.log

The correct behavior on AZP was tested and can be checked here: https://dev.azure.com/cncf/strimzi/_build/results?buildId=187634&view=results (under the published artifacts).

@im-konge im-konge added this to the 0.3.0 milestone Nov 11, 2025
@im-konge im-konge marked this pull request as ready for review November 11, 2025 13:34
@im-konge im-konge force-pushed the store-logs-correctly branch from 283895b to eb6bbe5 Compare November 11, 2025 16:09
@im-konge
debug
9988894 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge force-pushed the store-logs-correctly branch from eb6bbe5 to 9988894 Compare November 11, 2025 16:26
@im-konge
fixup! debug
9edabfe 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge
fixup! fixup! debug
bcf3585 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge self-assigned this Nov 11, 2025
@im-konge im-konge changed the title [ST] Add LogCollector and store logs from tests correctly on AZP [ST] Add LogCollector and store logs from tests in AZP Nov 11, 2025
@im-konge im-konge changed the title [ST] Add LogCollector and store logs from tests in AZP [ST] Add LogCollector and publish logs from tests in AZP Nov 11, 2025
@im-konge
remove debug stuff
f5c21bb 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge force-pushed the store-logs-correctly branch from d47be47 to f5c21bb Compare November 11, 2025 18:13
@im-konge
use mustgather
d7eb7ae 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge
changes
40e1571 
Signed-off-by: Lukas Kral <[email protected]>
@im-konge im-konge changed the title [ST] Add LogCollector and publish logs from tests in AZP [ST] Add MustGather and publish logs from tests in AZP Nov 12, 2025
kornys
kornys approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@kornys kornys left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

see-quick
see-quick approved these changes Nov 12, 2025
View reviewed changes
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @im-konge 👍 ... just a few minor nits to consider, nothing critical.

@im-konge
Maros' comments
02e50e7 
Signed-off-by: Lukas Kral <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@see-quick see-quick see-quick approved these changes

@katheris katheris Awaiting requested review from katheris

+1 more reviewer

@kornys kornys kornys approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@im-konge im-konge

Labels

None yet

Projects

None yet

Milestone

0.3.0

Development

Successfully merging this pull request may close these issues.

3 participants

@im-konge @kornys @see-quick